Bug Fix: Remove lazy loading from UCO header #1132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Autotagging @bigcommerce/stencil-team @davidchin |
davidchin
reviewed
Dec 7, 2017
templates/pages/checkout.html
Outdated
| @@ -17,7 +17,7 @@ <h1 class="is-srOnly">{{lang 'checkout.title'}}</h1> | |||
| <h2 class="checkoutHeader-heading"> | |||
| <a class="checkoutHeader-link" href="{{urls.home}}"> | |||
| {{#if checkout.header_image}} | |||
| <img alt="{{settings.store_logo.title}}" class="checkoutHeader-logo lazyload" id="logoImage" data-sizes="auto" src="{{cdn 'img/loading.svg'}}" data-src="{{ checkout.header_image }}"/> | |||
| <img alt="{{settings.store_logo.title}}" class="checkoutHeader-logo" id="logoImage" data-sizes="auto" src="{{ checkout.header_image }}"/> | |||
There was a problem hiding this comment.
Is data-sizes only required for lazy loading?
There was a problem hiding this comment.
I believe so. @BC-EChristensen can you confirm the above.
tabayomi
force-pushed
the
STRF-4138-checkout-logo
branch
from
91912fc
to
1cca6f6
Compare
tabayomi
force-pushed
the
STRF-4138-checkout-logo
branch
from
1cca6f6
to
b7c7e86
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR addresses a bug where the logo does not show up on the UCO cart page. This is due to some libraries required for lazy loading not being included on the UCO page.
Tickets / Documentation
STRF-4138
Screenshots (if appropriate)
cc @bigcommerce/stencil-team