STRF-2471 - Multiple Wish Lists #1134
Conversation
|
Autotagging @bigcommerce/stencil-team @davidchin |
|
Autotagging @bigcommerce/storefront-team |
lang/en.json
Outdated
| "you_have_none": "You have no wish lists, add one now.", | ||
| "empty_wishlist": "Your wish list is empty. When you add items to your wish list they will appear here.", | ||
| "heading": "Wish Lists", | ||
| "tag_line": "Fill in the form below to create a Wish List. Click the \"Save\" button when you're done.", |
There was a problem hiding this comment.
Is "Click the "Save" button when you're done" still accurate? Specifically the "Save." It looks like the button will get "Create New Wish List."
There was a problem hiding this comment.
good catch, the button in this case is actually "Create Wish List" without the "New". i've updated the copy, replacing "Save" with "Create Wish List".
|
@bigcommerce/storefront-team ♻️ |
CHANGELOG.md
Outdated
| @@ -14,6 +14,7 @@ | |||
| - Fixes issue with image zoom causing scrolling issues on mobile. [#1141](https://github.com/bigcommerce/cornerstone/pull/1141) | |||
| - Fix mis-sized product images. [#1145](https://github.com/bigcommerce/cornerstone/pull/1145) | |||
| - Remove "as low as" feature and add support for price ranges instead[#1143](https://github.com/bigcommerce/cornerstone/pull/1143) | |||
| - Implements Add to any Wish Lists capability. [#1134](https://github.com/bigcommerce/cornerstone/pull/1134) | |||
There was a problem hiding this comment.
This should be in the draft section.
| @@ -13,6 +13,8 @@ export default class WishList extends PageManager { | |||
| this.options = { | |||
| template: 'account/add-wishlist', | |||
| }; | |||
|
|
|||
| return this; | |||
There was a problem hiding this comment.
Any particular reason for doing a return here ?
There was a problem hiding this comment.
yeah, its so we can chain a call to one of it's methods: https://github.com/bigcommerce/cornerstone/pull/1134/files#diff-9c4b0efa294566acaa5d14e862d35bc7R20
lang/en.json
Outdated
| "you_have_none": "You have no wish lists, add one now.", | ||
| "empty_wishlist": "Your wish list is empty. When you add items to your wish list they will appear here.", | ||
| "heading": "Wish Lists", | ||
| "tag_line": "Fill in the form below to create a Wish List. Click the \"Create Wish List\" button when you're done.", |
There was a problem hiding this comment.
should we add the word new to Fill in the form below to create a Wish List. 🍹 .
What?
Tickets / Documentation
Screenshots
ping @bigcommerce/storefront-team