STRF-4282 - Add support in Cornerstone to consume AMP ID #1155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Autotagging @bigcommerce/storefront-team @davidchin |
mjschock
commented
Jan 24, 2018
templates/layout/amp.html
Outdated
| @@ -20,9 +20,9 @@ | |||
| {{{snippet 'htmlhead'}}} | |||
| <script async custom-element="amp-form" src="https://cdn.ampproject.org/v0/amp-form-0.1.js"></script> | |||
| <script async custom-element="amp-sidebar" src="https://cdn.ampproject.org/v0/amp-sidebar-0.1.js"></script> | |||
| {{#if theme_settings.amp_analytics_id}} | |||
| {{#or category.amp_analytics_id product.amp_analytics_id}} | |||
There was a problem hiding this comment.
this doesn't work - i need to find another way to do this
There was a problem hiding this comment.
nevermind - works just fine
|
@bigcommerce/storefront-team ♻️ |
1 similar comment
|
@bigcommerce/storefront-team ♻️ |
|
@junedkazi ♻️ |
junedkazi
approved these changes
Jan 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adds support to consume AMP ID (on the product and/or category rather than config)
Tickets
GIFs
http://g.recordit.co/eD9i23HoIt.gif
http://g.recordit.co/RpAKTvRMxh.gif
ping @bigcommerce/storefront-team @bookernath