CATALOG-2408 Fix updateView firing when there are no default options#1172
Merged
Conversation
Fix price reflowing when there are no default options, which was overriding price ranges.
|
Autotagging @bigcommerce/storefront-team @davidchin |
mjschock
approved these changes
Feb 27, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Fix price reflowing when there are no default options, which was overriding price ranges. We will now only update the PDP view when there are default option values, which will mirror the behavior of actually clicking on those options.
I took @bc-jz 's advice that it's better to override price ranges when there are default option values, so they do get overridden in that case to set shopper expectation around what price they'll get if they press "add to cart" right away.
As a future improvement, we might maintain price ranges if there are required options without default values (meaning I must click at least one option before I can add to cart). Might make sense to keep the range around in that case.
Tickets / Documentation
ping @bigcommerce/storefront-team