STRF-3168 - ItemAvailability schema for products #1174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Autotagging @bigcommerce/storefront-team @davidchin |
|
@bigcommerce/catalog-api-dt @bookernath |
junedkazi
reviewed
Mar 5, 2018
CHANGELOG.md
Outdated
|
|
||
| ## 1.13.2 (2018-02-28) | ||
| - Fix updateView firing when there are no default options. [#1172](https://github.com/bigcommerce/cornerstone/pull/1172) | ||
| - Don't clear bulk pricing rules when feature is disabled. [#1173](https://github.com/bigcommerce/cornerstone/pull/1173) |
There was a problem hiding this comment.
I am not sure I get what are these changelog entries for ? Did we miss it when we did 1.3.2 ?
There was a problem hiding this comment.
File it as a separate PR please.
junedkazi
approved these changes
Mar 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Why?
product.availabilityfield maps to the Availability text field under a product's Other Details section and therefore does not necessarily satisfy the enumerated fields for ItemAvailability. now we're explicitly selecting one of those enums depending on the product's fields. note that this will always show InStock when 'Track inventory by options' is enabled, regardless of the stock level of a variant.Tickets
Screenshots
before
after
ping @bigcommerce/storefront-team