fix(catalog): CATALOG-3085 default selection in quickview #1197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Autotagging @bigcommerce/storefront-team @davidchin |
megdesko
approved these changes
Apr 2, 2018
|
💚 - this update looks to be working as expected |
quickview by default when the modal is rendered unless theres an
actual default selection to be made.
junedkazi
approved these changes
Apr 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
refrain from updating the price shown on
quickview by default when the modal is rendered unless theres an
actual default selection to be made.
Tickets / Documentation
Screenshots (if appropriate)
Before: The quickview page would instantly make a request for stock/price based on selection even if the product doesnt have a default selection, which would result in getting the base price.
After: The quickview page still makes the default request so that it can mark things as OOS when necessary, but it doesnt try to change the price in the view if its not applicable.
