STRF-4827 - Fix review showing on products that do not have any reviews#1209
Merged
junedkazi merged 1 commit intobigcommerce:masterfrom May 2, 2018
bookernath:STRF-4827
Merged
STRF-4827 - Fix review showing on products that do not have any reviews#1209junedkazi merged 1 commit intobigcommerce:masterfrom bookernath:STRF-4827
junedkazi merged 1 commit intobigcommerce:masterfrom
bookernath:STRF-4827
Conversation
|
Autotagging @bigcommerce/storefront-team @davidchin |
junedkazi
suggested changes
Apr 24, 2018
Contributor
junedkazi
left a comment
junedkazi
left a comment
There was a problem hiding this comment.
Changes look good. This change will need a change log entry as well. Also we should hold off on merging this one till we release 1.17.0
Contributor
|
@bookernath can you fix the changelog & move it to draft section again so we can merge this change. |
I've updated the conditional to check both if reviews are intended to be shown (in the theme's settings) as well and if there are any reviews.
junedkazi
approved these changes
May 2, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
I've updated the conditional to check both if reviews are intended to be shown (in the theme's settings) as well and if there are any reviews.
Tickets / Documentation
Add links to any relevant tickets and documentation.
Screenshots (if appropriate)
Before:
After: