STRF-4146: Don't lazy load logo if size is unknown #1213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Autotagging @bigcommerce/storefront-team @davidchin |
* Our lazy loading solution relies on advance knowledge of the image dimensions. When `logo_size` is set to `original` in the theme settings, we don't have this information. For large logos, this leads to overlapping of the menu. * For original sized images, don't use lazy loading or reserving space for the image via absolute positioning. Hopefully not many users will use this setting because it will impact frontend performance. In order to hopefully minimize this, I reordered the options for logo_size so our optimized setting appears first in the list.
junedkazi
approved these changes
Apr 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
logo_sizeis set tooriginalin the theme settings, we don't have this information. For large logos, this leads to overlapping of the menu.logo_sizeso our optimized setting appears first in the list.schema.jsonis due to changing the line endings from dos to unix. The only change of substance is reordering the options forlogo_sizeTickets / Documentation
Screenshots
Before
After
With "original" sized logo (desktop)
With "original" sized logo (mobile)
With "optimized for theme" sized logo (250x100) (desktop):
With "optimized for theme" sized logo (250x100) (mobile):