fix(storefront): STRF-4840 Options hide Add To Cart in AMP. #1214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
On a Google AMP Product Page, Options would hide Add to Cart under a very specific set of conditions. This only affected products with options.
It seems that some CSS is targeting what was originally
<div data-product-option-change style="display:none;">. When this style was removed it would cause issues if Options would "push" Add to Cart below the viewable window.Because this code is only called if there are product options to begin with (see
templates/components/amp/products/product-view, there's no need to have a style that would hide it on-load.Tested in macOS Sierra on Chrome, Firefox 55, and Safari, and on Android Chrome with a Nokia 6.
Tickets / Documentation