Fix minor ESLint errors in webpack.common.js#1280
Merged
junedkazi merged 1 commit intobigcommerce:masterfrom Jun 29, 2018
sacr3dc0w:late-spring-cleaning
Merged
Fix minor ESLint errors in webpack.common.js#1280junedkazi merged 1 commit intobigcommerce:masterfrom sacr3dc0w:late-spring-cleaning
junedkazi merged 1 commit intobigcommerce:masterfrom
sacr3dc0w:late-spring-cleaning
Conversation
junedkazi
reviewed
Jun 28, 2018
CHANGELOG.md
Outdated
| - Fix prices not showing in quick search while logged in when "Restrict to Login" for price display is true [#1272](https://github.com/bigcommerce/cornerstone/pull/1272) | ||
| - Display product reviews in tabbed content region of product page [#1273](https://github.com/bigcommerce/cornerstone/pull/1273) | ||
| - Fix duplicate input ID's in product review form [#1276](https://github.com/bigcommerce/cornerstone/pull/1276) | ||
| - Fix for ESLint "quotes" and "quote-props" errors. [#1280](https://github.com/bigcommerce/cornerstone/pull/1280) |
Contributor
There was a problem hiding this comment.
@sacr3dc0w can you just move this into the draft section please.
junedkazi
approved these changes
Jun 28, 2018
-Strings must use singlequote. (quotes) 45:39 -Unnecessarily quoted property 'lazysizes' found. (quote-props) 63:13 -Unnecessarily quoted property 'pace' found. (quote-props) 64:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Just some minor cleanup for consistency in
webpack.common.jsby removing unnecessary quotes from single string properties and use single quotes for theme bundle output path. Added benefit of removing ESLint errors thrown in Atom.Strings must use singlequote. (quotes) 45:39Unnecessarily quoted property 'lazysizes' found. (quote-props) 63:13Unnecessarily quoted property 'pace' found. (quote-props) 64:13