Corrects mini cart display issues#1298
Merged
Ubersmake merged 2 commits intobigcommerce:masterfrom Aug 1, 2018
sacr3dc0w:mini-cart
Merged
Corrects mini cart display issues#1298Ubersmake merged 2 commits intobigcommerce:masterfrom sacr3dc0w:mini-cart
Ubersmake merged 2 commits intobigcommerce:masterfrom
sacr3dc0w:mini-cart
Conversation
|
Autotagging @bigcommerce/storefront-team @davidchin |
Closed
Ubersmake
approved these changes
Aug 1, 2018
Contributor
Ubersmake
left a comment
Ubersmake
left a comment
There was a problem hiding this comment.
👍 Thank you!
For future reference, it looks like this issue is (or was) most apparent for non-mobile widths if you change the viewport while the mini cart preview is displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
In certain cases, the mini cart dropdown was displaying basically entirely out of the viewport. This corrects that problem. I also noticed an alignment problem with the mini cart css arrow and the cart quantity badge in mobile viewports. This alignment problem was there before the dropdown viewport fix but became more apparent, so this squashes that.
Tickets / Documentation
GIF/screenshots
Viewport fix, before (gif)
Viewport fix, after (gif)
Mobile alignment, before
Mobile alignment, after
