Open product tabs on load.#1304
Merged
Ubersmake merged 2 commits intobigcommerce:masterfrom Jul 11, 2018
Ubersmake:AnchorTabs
Merged
Open product tabs on load.#1304Ubersmake merged 2 commits intobigcommerce:masterfrom Ubersmake:AnchorTabs
Ubersmake merged 2 commits intobigcommerce:masterfrom
Ubersmake:AnchorTabs
Conversation
|
Autotagging @bigcommerce/storefront-team @davidchin |
tpietsch
approved these changes
Jul 9, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
#1220 but with an additional guard for non-existent tab names.
This only works on page load. Because the hash isn't technically an HTML anchor, browsers have no idea what "anchor" to view and will end up doing nothing.
Additionally, the guard for non-existent tab names might not be necessary. As far as the code is concerned the JS will attempt to operate on nothing. But
$activeTab.length > 0definitely makes sure it doesn't run.Tickets / Documentation
Screenshots
Tab:
Definitely Not a Tab:
