Undo New Products left align from 2.3.0. #1328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Reverting #1321 until we can find a better solution for all cases. New products were left-aligned, but once there were four products the fourth product would be pushed into a new row.
The caveat here is that merchants who are displaying less than four new products on Cornerstone should probably keep the changes to
_productCarousel.scssin ca0f3cd.Tickets / Documentation
Screenshots
Before (2.3.1)
3 Products
5 Products
After (or 2.2.1)
3 Products. Note the justification.
5 Products. Note the carousel.