Skip to content

added unique id for swatch options#1347

Merged
1 commit merged intomasterfrom
unknown repository
Sep 21, 2018
Merged

added unique id for swatch options#1347
1 commit merged intomasterfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Sep 14, 2018

What?

If an option set includes multiple similar options group for ex: multiple color options in one set, than any selection in any set reflects only on the first group.

Screenshots

Swatch
Product view

screen shot 2018-09-14 at 1 43 57 pm

Modal

screen shot 2018-09-14 at 1 44 07 pm

Cart

screen shot 2018-09-14 at 1 45 18 pm

CP orders

screen shot 2018-09-14 at 1 47 59 pm

Set-Rectangle
Product view

screen shot 2018-09-14 at 2 11 32 pm

Modal

screen shot 2018-09-14 at 2 11 42 pm

Cart

screen shot 2018-09-14 at 2 11 52 pm

Set-Radio
Product view

screen shot 2018-09-14 at 2 30 46 pm

Modal

screen shot 2018-09-14 at 2 30 56 pm

Cart

screen shot 2018-09-14 at 2 31 12 pm

Product-List
Product view

screen shot 2018-09-14 at 3 00 37 pm

Moda

screen shot 2018-09-14 at 3 00 46 pm

Cart

screen shot 2018-09-14 at 3 00 54 pm

SKU

Cart

screen shot 2018-09-14 at 3 43 38 pm

CP

screen shot 2018-09-14 at 3 44 50 pm

Price-List

screen shot 2018-09-14 at 3 57 16 pm

@junedkazi
Copy link
Copy Markdown
Contributor

@bookernath @bigcommerce/catalog-dt

@bigbot
Copy link
Copy Markdown

bigbot commented Sep 14, 2018

Autotagging @bigcommerce/storefront-team @davidchin

@Ubersmake
Copy link
Copy Markdown
Contributor

💚

This has been run against BC's product and price list test suites.

Copy link
Copy Markdown
Contributor

@Ubersmake Ubersmake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM. Please rebase, as 2.4.0 has been released at the time of this PR.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants