added unique id for swatch options#1347
Merged
1 commit merged intomasterfrom Sep 21, 2018
unknown repository
Merged
Conversation
Contributor
|
@bookernath @bigcommerce/catalog-dt |
|
Autotagging @bigcommerce/storefront-team @davidchin |
Contributor
|
💚 This has been run against BC's product and price list test suites. |
Ubersmake
approved these changes
Sep 19, 2018
Contributor
Ubersmake
left a comment
Ubersmake
left a comment
There was a problem hiding this comment.
👍 LGTM. Please rebase, as 2.4.0 has been released at the time of this PR.
ghost
merged commit 
This was referenced Apr 9, 2019
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
If an option set includes multiple similar options group for ex: multiple color options in one set, than any selection in any set reflects only on the first group.
Screenshots
Swatch
Product view
Modal
Cart
CP orders
Set-Rectangle
Product view
Modal
Cart
Set-Radio
Product view
Modal
Cart
Product-List
Product view
Moda
Cart
SKU
Cart
CP
Price-List