Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MERC-3746 cornerstone schema change #1350

Merged
merged 1 commit into from
Sep 21, 2018

Conversation

kchu93
Copy link
Contributor

@kchu93 kchu93 commented Sep 19, 2018

What?

Cornerstone - Update Schema labels and organization;
Updated the labels and organization of cornerstone of schema.json entries.

Why?

In preparation for launching Store Design, the merchandising team performed an audit on the cornerstone settings that are available finding a large number of usability gaps. As a short-term solution, the team made the following changes focusing on providing a better legibility of the setting.

  • Update labels on all entries to use updated, consistent language
  • Provide better organization by creating new groupings of settings
  • User clarity and consistency

Tickets / Documentation

Add links to any relevant tickets and documentation.

schema.json Show resolved Hide resolved
},
{
"type": "paragraph",
"content": "* the 'Product price label' is displayed when there is not a sale price."
"content": "* the 'Product price label' is displayed when there is not a sale price.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't we need force reload for type paragraph ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is just a

element, and shouldn't need a force reload as we are not making any changes. @pedelman

Copy link
Contributor

@junedkazi junedkazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kchu93 awesome work on this one 👏 . Can you add a changelog entry as well for the PR.

@Ubersmake can we do some smoke test on this one. Just randomly test some of the changes part of this PR and make sure everything is working as expected.

@Ubersmake
Copy link
Contributor

Ubersmake commented Sep 19, 2018

💚

I've tested one of the sections changed in schema.json and that's in order.

I also tried uploading a version without the changes in this PR, saving a configuration, and then upgrading that theme to one with the changes in schema.json. The configuration changes that were saved were carried over into the upgraded version, even though the names of two of the elements ("Global" and "Horizontal line") have changed.

@kchu93 kchu93 force-pushed the schemachange branch 2 times, most recently from 04da948 to ccbbde7 Compare September 21, 2018 22:56
@Ubersmake Ubersmake merged commit 4e8c212 into bigcommerce:master Sep 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants