taruntds's "Added "activePage" as a active class in navigation menu and web pages" #1354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Autotagging @bigcommerce/storefront-team @davidchin |
davidwrpayne
approved these changes
Sep 24, 2018
junedkazi
reviewed
Sep 24, 2018
| @@ -16,7 +16,7 @@ | |||
| {{#unless theme_settings.hide_content_navigation}} | |||
| {{#each pages}} | |||
| <li class="navPages-item navPages-item-page"> | |||
| <a class="navPages-action" href="{{url}}">{{name}}</a> | |||
| <a class="navPages-action{{#if name '==' ../page.title}} activePage{{/if}}" href="{{url}}">{{name}}</a> | |||
There was a problem hiding this comment.
This is for the parent-page scenario. If a page is nested in a tree this will highlight both the current page and its parent, like in: https://user-images.githubusercontent.com/1546172/45905025-c491ab80-bda3-11e8-8302-fab27866a954.png , where the page is "Bath" but "Bath" is in the "Shop All" category.
junedkazi
approved these changes
Sep 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
A new PR for #1335
The active page has the same styling as a navigation link on hover.
Tickets / Documentation
#1335
Screenshots
Category Page (Bath):
Before:
After:
Narrow Category Page (Publications):
Before:
After:
Nested Category Page (Shop All > Bath):
Before:
After:
Narrow Nested Category Page (Shop All > Bath):
Before:
After:
