STRF-5474 Improve performance of first carousel slide #1356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Autotagging @bigcommerce/storefront-team @davidchin |
mattolson
reviewed
Sep 24, 2018
mattolson
reviewed
Sep 24, 2018
templates/layout/base.html
Outdated
| @@ -3,6 +3,11 @@ | |||
| <head> | |||
| <title>{{ head.title }}</title> | |||
| {{{ resourceHints }}} | |||
|
|
|||
| {{#if carousel.slides.[0].image}} | |||
There was a problem hiding this comment.
Have you tested this with a store with no carousel? Interested to know what the context looks like in that case and whether this conditional still works.
mattolson
approved these changes
Sep 24, 2018
-rel=preload tag for first carousel slide (if present) -don't lazyload first slide
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
-Don't lazyload first slide (avoids FOUC and weird behavior)
-Tiny refactor replacing multiple #if statements with #and
-rel=preload tag for first carousel slide (if present) to improve download timewill do this laterTickets / Documentation
Add links to any relevant tickets and documentation.
ping @junedkazi @mattolson @bc-zoharmuzafi