Product review modal error message is now accurate.#1370
Merged
Ubersmake merged 1 commit intobigcommerce:masterfrom Oct 11, 2018
Ubersmake:STRF-5418
Merged
Product review modal error message is now accurate.#1370Ubersmake merged 1 commit intobigcommerce:masterfrom Ubersmake:STRF-5418
Ubersmake merged 1 commit intobigcommerce:masterfrom
Ubersmake:STRF-5418
Conversation
|
Autotagging @bigcommerce/storefront-team @davidchin |
junedkazi
approved these changes
Oct 11, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
The product review modal currently returns an error message that fields are blank during pre-submit form field validation. This happens when the Subject and Comments fields have entries with 1 character. Code-wise, validation only passes when there is an input of minimum length 2.
This PR changes this so that the error message is accurate. If the forms are blank, the error message about form fields being blank will appear. If the forms are not blank, they won't.
Screenshots
Before
After