Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Remove Oswald logo font to reduce number of unique fonts, improve pe… #1375
Most stores will upload a logo image, so having a unique font just for the text logo is a waste of bandwidth in the browser.
Changing logo font to one of the existing fonts to reduce download and lookups of fonts.
Tickets / Documentation
Screenshots (if appropriate)
We should note that this is a breaking change of sorts. It's not serious, but here is the scenario: If someone is using a logo font, their current configuration is set to use one of
We have to be comfortable with the logo font for stores changing after upgrade and upon the next Theme Editor save in order to proceed with this PR.
We should test this upgrade behavior as well to make sure I've described it accurately.
This still doesn't guarantee that we'll end up with only two fonts on the page. There are many font options available for different font settings, and we will always load the union of all the font selections.
Another approach would be to eliminate this setting entirely and change the CSS to use one of the other font settings, such as