Remove Oswald logo font to reduce number of unique fonts, improve pe… #1375
Conversation
|
Autotagging @bigcommerce/storefront-team @davidchin |
There was a problem hiding this comment.
We should note that this is a breaking change of sorts. It's not serious, but here is the scenario: If someone is using a logo font, their current configuration is set to use one of Google_Oswald_400 or Google_Oswald_300. When they upgrade Cornerstone, their configuration will be using a value that no longer exists in the theme, so the next time they use Theme Editor / Store Design, it will select one of the new values by default (probably Google_Montserrat_400 because it is listed first), and when they save, it will save that value.
We have to be comfortable with the logo font for stores changing after upgrade and upon the next Theme Editor save in order to proceed with this PR.
We should test this upgrade behavior as well to make sure I've described it accurately.
|
I have updated this PR to make it a less breaking change, by keeping the original fonts around as selectable options. |
There was a problem hiding this comment.
This still doesn't guarantee that we'll end up with only two fonts on the page. There are many font options available for different font settings, and we will always load the union of all the font selections.
Another approach would be to eliminate this setting entirely and change the CSS to use one of the other font settings, such as headings-font: https://github.com/bigcommerce/cornerstone/blob/master/schema.json#L134
|
@mattolson ♻️ |
There was a problem hiding this comment.
LGTM. @Ubersmake Can you test this out and confirm my understanding of the configuration upgrade process?
|
@bookernath Needs rebase |
|
💚 |
…rformance Most stores will update a logo image, so having a unique font just for the text logo is a waste of performance in the browser. Changing logo font to one of the existing fonts to reduce download and lookups of fonts.
bookernath
changed the title
…rformance
What?
Most stores will upload a logo image, so having a unique font just for the text logo is a waste of bandwidth in the browser.
Changing logo font to one of the existing fonts to reduce download and lookups of fonts.
Tickets / Documentation
Screenshots (if appropriate)