Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STRF-4612 - Remove unnecessary API call to get cookie notification st… #1380

Merged
merged 1 commit into from Nov 9, 2018
Merged

STRF-4612 - Remove unnecessary API call to get cookie notification st… #1380

merged 1 commit into from Nov 9, 2018

Conversation

@bookernath
Copy link
Contributor

@bookernath bookernath commented Nov 8, 2018

…atus

What?

You can already infer the status of the cookie setting from the presence of cookie notification text; this property returns false if the setting is disabled. So this API call was unnecessary. It has been deprecated and removed in stencil-utils as of 2.0.

This handlebars check is enough: https://github.com/bigcommerce/cornerstone/blob/master/templates/layout/base.html#L35

Tickets / Documentation

Dependencies

Depends on bigcommerce/stencil-utils#87 and a stencil-utils bump

Video

http://recordit.co/U3qUIDCHl4

@bigbot
Copy link

@bigbot bigbot commented Nov 8, 2018

@mattolson
Copy link
Member

@mattolson mattolson commented Nov 9, 2018

I have published stencil-utils 2.0, which you should bring into this PR.

…atus

You can already infer the status of the cookie setting from the presence of cookie notification text; this property returns false if the setting is disabled. So this API call was unnecessary.
@mattolson
Copy link
Member

@mattolson mattolson commented Nov 9, 2018

wow

@mattolson mattolson merged commit e2cbbe4 into bigcommerce:master Nov 9, 2018
@bookernath bookernath deleted the STRF-4612 branch Nov 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants