STRF-4612 - Remove unnecessary API call to get cookie notification st… #1380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Autotagging @bigcommerce/storefront-team @davidchin |
|
I have published stencil-utils 2.0, which you should bring into this PR. |
…atus You can already infer the status of the cookie setting from the presence of cookie notification text; this property returns false if the setting is disabled. So this API call was unnecessary.
mattolson
approved these changes
Nov 9, 2018
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…atus
What?
You can already infer the status of the cookie setting from the presence of cookie notification text; this property returns false if the setting is disabled. So this API call was unnecessary. It has been deprecated and removed in stencil-utils as of 2.0.
This handlebars check is enough: https://github.com/bigcommerce/cornerstone/blob/master/templates/layout/base.html#L35
Tickets / Documentation
Dependencies
Depends on bigcommerce/stencil-utils#87 and a stencil-utils bump
Video
http://recordit.co/U3qUIDCHl4