New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

defer loading of addthis #1406

Merged
merged 1 commit into from Dec 18, 2018

Conversation

Projects
None yet
3 participants
@bc-zoharmuzafi
Copy link
Contributor

bc-zoharmuzafi commented Dec 13, 2018

What?

defer loading of addthis for faster loading pages.

Screenshots (if appropriate)

Before

screen shot 2018-12-12 at 9 21 39 pm

After

screen shot 2018-12-12 at 9 22 54 pm

@bigbot

This comment has been minimized.

Copy link

bigbot commented Dec 13, 2018

Show resolved Hide resolved templates/components/common/share.html Outdated

@bc-zoharmuzafi bc-zoharmuzafi force-pushed the bc-zoharmuzafi:add_this branch from b259fcc to 2fbc152 Dec 17, 2018

@bc-zoharmuzafi bc-zoharmuzafi force-pushed the bc-zoharmuzafi:add_this branch from 2fbc152 to 4356631 Dec 17, 2018

Show resolved Hide resolved templates/components/common/share.html Outdated

@bc-zoharmuzafi bc-zoharmuzafi force-pushed the bc-zoharmuzafi:add_this branch from 4356631 to 1240308 Dec 17, 2018

Needs changelog entry

@mattolson

This comment has been minimized.

Copy link
Member

mattolson commented Dec 17, 2018

@bc-zoharmuzafi 👍 LGTM but can you add a CHANGELOG entry?

@bc-zoharmuzafi bc-zoharmuzafi force-pushed the bc-zoharmuzafi:add_this branch from 1240308 to 4761c2a Dec 18, 2018

@bc-zoharmuzafi bc-zoharmuzafi merged commit 71163f1 into bigcommerce:master Dec 18, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment