Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

defer loading of addthis #1406

Merged
1 commit merged into from Dec 18, 2018
Merged

defer loading of addthis #1406

1 commit merged into from Dec 18, 2018

Conversation

ghost
Copy link

@ghost ghost commented Dec 13, 2018

What?

defer loading of addthis for faster loading pages.

Screenshots (if appropriate)

Before

screen shot 2018-12-12 at 9 21 39 pm

After

screen shot 2018-12-12 at 9 22 54 pm

@bigbot
Copy link

bigbot commented Dec 13, 2018

Autotagging @bigcommerce/storefront-team @davidchin

templates/components/common/share.html Outdated Show resolved Hide resolved
templates/components/common/share.html Outdated Show resolved Hide resolved
mattolson
mattolson previously approved these changes Dec 17, 2018
@mattolson mattolson dismissed their stale review December 17, 2018 23:12

Needs changelog entry

@mattolson
Copy link
Contributor

@bc-zoharmuzafi 👍 LGTM but can you add a CHANGELOG entry?

@ghost ghost merged commit 71163f1 into bigcommerce:master Dec 18, 2018
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants