Fixed the issue - sending GA event for last product removed from CART.#1409
Merged
bc-ranji merged 1 commit intobigcommerce:masterfrom Jan 2, 2019
Merged
Fixed the issue - sending GA event for last product removed from CART.#1409bc-ranji merged 1 commit intobigcommerce:masterfrom
bc-ranji merged 1 commit intobigcommerce:masterfrom
Conversation
|
Autotagging @bigcommerce/storefront-team @davidchin |
lord2800
approved these changes
Dec 18, 2018
Contributor
lord2800
left a comment
There was a problem hiding this comment.
cc @junedkazi @BC-EChristensen @mattolson
Contributor
|
💚 |
Contributor
|
@Ubersmake whenever the next cornerstone release is planned for, can this be added to the list of things to merge? |
d767557 to
876a732
Compare
876a732 to
e2d9ad1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
When cart has single product and it is removed - product removed event is not sent
Tickets / Documentation
https://jira.bigcommerce.com/browse/CP-4054
Screenshots (if appropriate)