Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(customers): CUST-391 allow enter empty phone number when updatin… #1417

Merged
merged 1 commit into from
Jan 16, 2019
Merged

feat(customers): CUST-391 allow enter empty phone number when updatin… #1417

merged 1 commit into from
Jan 16, 2019

Conversation

victor-ivanov
Copy link

@victor-ivanov victor-ivanov commented Jan 9, 2019

What?

allow enter empty phone number when updating account settings in storefront

Tickets / Documentation

Add links to any relevant tickets and documentation.

PR for server side which updates account validation to allow empty phone numbers https://github.com/bigcommerce/bigcommerce/pull/27974

Screenshots (if appropriate)

Attach images or add image links here.
image

@bigcommerce/storefront-team @bigcommerce/customers

@bigbot
Copy link

bigbot commented Jan 9, 2019

Autotagging @bigcommerce/storefront-team @davidchin

@Ubersmake
Copy link
Contributor

Please note that this is not the same thing as STRF-4102, which was addressed in https://github.com/bigcommerce/bigcommerce/pull/24290.

@victor-ivanov
Copy link
Author

I've executed basic, full ui, full http, full api test suites on PR with this theme applied https://github.com/bigcommerce/bigcommerce/pull/28004

full api fails due to 429 [reason phrase] Too Many Requests but I dont think it related to theme changes.

We are going to start manual testing on this PR to validate that problem with phone update was fixed.

@bigcommerce/storefront-team could you please review this PR?

@Ubersmake
Copy link
Contributor

Merging this. Some important thing to keep in my mind regarding this ticket/feature:

  • Customer Phone Number is different from Address Phone Number
  • When a user creates a new account through the storefront, the phone number they enter is copied to both the Customer and Customer Address.
  • When a user edits their account, the phone number they enter there only affects the Customer Phone Number.
  • Form Field requirement settings only apply to Address Phone Number.

At present, on the Bigcommerce backend, Customer Phone Number is optional. Address Phone Number is determined by the merchant.

@Ubersmake Ubersmake merged commit 8e7fa2f into bigcommerce:master Jan 16, 2019
Ubersmake added a commit that referenced this pull request Jan 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants