STRF-4173 - Ensure SKU and UPC display correctly for Variants when th…#1431
Merged
Conversation
|
Autotagging @bigcommerce/storefront-team @davidchin |
Ubersmake
approved these changes
Jan 23, 2019
Contributor
Ubersmake
left a comment
Ubersmake
left a comment
There was a problem hiding this comment.
LGTM. Please add an entry to CHANGELOG.md.
junedkazi
reviewed
Jan 23, 2019
| $upc: $('[data-product-upc]'), | ||
| sku: { | ||
| $dt: $('dt.sku-label', $scope), | ||
| $dd: $('[data-product-sku]', $scope), |
Contributor
There was a problem hiding this comment.
can we just name the keys as label and value so it is easier to read.
Contributor
Author
There was a problem hiding this comment.
yea I suppose so - was just following the format already in place
junedkazi
reviewed
Jan 23, 2019
| }, | ||
| upc: { | ||
| $dt: $('dt.upc-label', $scope), | ||
| $dd: $('[data-product-upc]', $scope), |
…ey are not set on base product.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ey are not set on base product.
What?
For complex products, if you do not set SKU or UPC on the base product level, then the SKU/UPC will not display on the PDP and QuickView popup on PLP. These changes correct this issue ensuring that variant level SKU/UPC can always display on PDP and PLP.
The SKU/UPC label values will also now hide if there is not a SKU associated with the particular selection.
Tickets / Documentation
JIRA
Screenshots (if appropriate)
On my branch
Initial page load - there is not a SKU or UPC on base product:
Choosing selections that have a SKU and UPC set on Variant:
