Fix submenu click on mobile navigation #1472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Autotagging @bigcommerce/storefront-team @davidchin |
|
Hi @kylebolstad . I'm trying to reproduce the issue this PR fixes, and I'm not sure how to set things up. How do I get mobile navigation into a state where sibling elements are not being shown or hidden correctly? |
|
@Ubersmake Good point! I totally forgot to mention that this seems to only happen when |
|
Thanks for this. I'm attaching GIFs so that anyone looking at this PR knows what actually changed. It took me some time to figure out what was being affected: expanding and collapsing category navigation. Before: After: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Change the event handler to correctly call
this.onSubMenuClick. Without this fix, mobile navigation is not showing/hiding siblings correctly.