Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update babel/polyfill to 7.4.4 #1521

Merged
merged 1 commit into from Jun 27, 2019
Merged

Update babel/polyfill to 7.4.4 #1521

merged 1 commit into from Jun 27, 2019

Conversation

bookernath
Copy link
Contributor

What?

Update babel/polyfill to latest, as it's 6 months out of date.

Next, we'll need to replace it: https://babeljs.io/docs/en/babel-polyfill

@mattolson
Copy link
Contributor

@bookernath This should be fine, but I'm concerned about the large diff in package-lock.json. Can you do this again, following the procedure outlined in the readme? We should keep the version of Node and npm consistent to minimize the diff.

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@junedkazi junedkazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might have to regenerate the lock after cornerstone release unless we plan on merging this PR and creating rc2.

@bookernath bookernath merged commit ef27d20 into bigcommerce:master Jun 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants