Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STRF-6042 add maxlength to text options #1531

Merged
merged 2 commits into from
Jun 28, 2019
Merged

Conversation

bdav87
Copy link
Contributor

@bdav87 bdav87 commented Jun 27, 2019

What?

Including the maxlength attribute on text input options and multi line text options if a max length value has been defined by the merchant.

Tickets / Documentation

https://jira.bigcommerce.com/browse/STRF-6042

@bigbot
Copy link

bigbot commented Jun 27, 2019

Autotagging @bigcommerce/storefront-team @davidchin

bookernath
bookernath previously approved these changes Jun 27, 2019
Copy link
Contributor

@bookernath bookernath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a changelog.

@mattolson mattolson merged commit 162c120 into bigcommerce:master Jun 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants