Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PAYMENTS-4520 Fix incorrect DOM selectors causing the payment method form on the account page from working properly in Safari #1541

Merged
merged 1 commit into from
Jul 19, 2019
Merged

PAYMENTS-4520 Fix incorrect DOM selectors causing the payment method form on the account page from working properly in Safari #1541

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
- Fix broken conditional statement in share.html [#1533](https://github.com/bigcommerce/cornerstone/pull/1533)
- Enable Facebook like button to be displayed on product page if enabled [#1530](https://github.com/bigcommerce/cornerstone/pull/1530)
- Remove nanobar (loading bar) [#1537](https://github.com/bigcommerce/cornerstone/pull/1537)
- Fix incorrect DOM selectors causing the payment method form on the account page from working properly in Safari [#1541](https://github.com/bigcommerce/cornerstone/pull/1541)

## 3.5.1 (2019-06-24)
- Fix conditional logic in share.html [#1522](https://github.com/bigcommerce/cornerstone/pull/1522)
Expand Down
4 changes: 2 additions & 2 deletions assets/js/theme/account.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,7 @@ export default class Account extends PageManager {
$(`${paymentMethodSelector} input[name="credit_card_number"]`).on('keyup', ({ target }) => {
cardType = creditCardType(target.value);
if (cardType) {
$(`${paymentMethodSelector} img[alt="${cardType}"`).siblings().css('opacity', '.2');
$(`${paymentMethodSelector} img[alt="${cardType}"]`).siblings().css('opacity', '.2');
} else {
$(`${paymentMethodSelector} img`).css('opacity', '1');
}
Expand All @@ -269,7 +269,7 @@ export default class Account extends PageManager {

// Set of credit card format
CCFormatters.setCreditCardNumberFormat(`${paymentMethodSelector} input[name="credit_card_number"]`);
CCFormatters.setExpirationFormat(`${paymentMethodSelector} input[name="expiration"`);
CCFormatters.setExpirationFormat(`${paymentMethodSelector} input[name="expiration"]`);

// Billing address validation
paymentMethodValidator.add(validationModel);
Expand Down