Fixes #155
Merged
Fixes #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
| font-size: fontSize("tiny"); | ||
| color: color("greys", "dark"); | ||
| letter-spacing: letterSpacing("large"); | ||
| font-style: italic; |
ghost
merged commit
| @@ -30,7 +30,9 @@ <h4 class="listItem-title"> | |||
| {{/if}} | |||
| {{/unless}} | |||
| {{#if show_compare}} | |||
| <a href="#" class="button button--compare">Compare</a> | |||
| <label class="button button--small" for="{{id}}"> | |||
There was a problem hiding this comment.
Should namespace your for's id attribute, i.e., for="compare-{{id}}" since id is being auto-generated and could cause id conflicts in the future.
There was a problem hiding this comment.
Will actually fix this one along with the card component as part of another PR.
|
@haubc you should've become a linter for a living 😛 |
|
|
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Few minor fixes I made while going through stencil
@SiTaggart @bc-chris-roper @bc-edlou