BIG-16069: Faceted search component #158
Conversation
|
@bc-miko-ademagic @SiTaggart |
| border-bottom-width: 0; | ||
| } | ||
|
|
||
| &.is-open > .accordion-navigation { |
There was a problem hiding this comment.
.accordion--navList > .accordion-block:last-child.is-open > .accordion-navigation { ... }
WOW much specificity
There was a problem hiding this comment.
lol, yeah pretty crazy. I tried really hard using foundation.accordion.js, which I ended up with nasty nested accordions and didn't produce the result I wanted. Anyway, in b99da27 I decided to not use foundation.accordion.js and created a generic Collapsible class to handle collapse/expand interaction. So now all the child descendant selectors are no longer needed.
|
Tested locally and this looks really good so far: https://dl.dropboxusercontent.com/spa/jd5nszcz7axrfas/96849__p.png |
|
Not sure if we ever received a design for the AJAX loading state indicator but perhaps it should be more visible somewhere, dimming the entire product results box or something like that. |
|
@christopher-hegre haven't received the loading indicator yet, but it's been requested now. |
|
I revised the PR based on the feedback. Please note that it now requires the change in bigcommerce/paper#18 @SiTaggart @bc-chris-roper @haubc @christopher-hegre |
| // | ||
| // ----------------------------------------------------------------------------- | ||
| .toggleLink { | ||
| .toggleLink-text--off { |
There was a problem hiding this comment.
Does this need to be nested?
There was a problem hiding this comment.
No they don't. I've updated it.
|
Just some of those minor things, but on the whole looks good |
|
@SiTaggart so I also configured |
|
👍 Awesome. Heaps better. Only stylistic thing is a clear line break under each comment block in the scss files as per the style guide, but I'll just merge for now. |
BIG-16069: Faceted search component
Faceted search component UI. There are several things to check:
It does not exactly match the design - for example, color options and price range slider, which could be worked on separately.
@bc-chris-roper @haubc @christopher-hegre