Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix corejs warning #1594

Merged
merged 1 commit into from Nov 7, 2019

Conversation

@bookernath
Copy link
Contributor

bookernath commented Nov 7, 2019

What?

Fixing this error on stencil start:

WARNING: We noticed you're using the `useBuiltIns` option without declaring a core-js version. Currently, we assume version 2.x when no version is passed. Since this default version will likely change in future versions of Babel, we recommend explicitly setting the core-js version you are using via the `corejs` option.

You should also be sure that the version you pass to the `corejs` option matches the version specified in your `package.json`'s `dependencies` section. If it doesn't, you need to run one of the following commands:

  npm install --save core-js@2    npm install --save core-js@3
  yarn add core-js@2              yarn add core-js@3
@bookernath bookernath requested a review from mattolson Nov 7, 2019
@bookernath bookernath force-pushed the bookernath:fix-corejs branch from 3d7a223 to 9b5e056 Nov 7, 2019
@bookernath bookernath requested a review from junedkazi Nov 7, 2019
@bookernath bookernath force-pushed the bookernath:fix-corejs branch from 9b5e056 to 4ac1c73 Nov 7, 2019
@bookernath bookernath force-pushed the bookernath:fix-corejs branch from 4ac1c73 to a0490ee Nov 7, 2019
@bc-jz
bc-jz approved these changes Nov 7, 2019
Copy link
Contributor

bc-jz left a comment

LGTM

@bookernath bookernath merged commit ac50765 into bigcommerce:master Nov 7, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@bookernath bookernath deleted the bookernath:fix-corejs branch Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.