Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix corejs warning #1594

Merged
merged 1 commit into from
Nov 7, 2019
Merged

Fix corejs warning #1594

merged 1 commit into from
Nov 7, 2019

Conversation

bookernath
Copy link
Contributor

What?

Fixing this error on stencil start:

WARNING: We noticed you're using the `useBuiltIns` option without declaring a core-js version. Currently, we assume version 2.x when no version is passed. Since this default version will likely change in future versions of Babel, we recommend explicitly setting the core-js version you are using via the `corejs` option.

You should also be sure that the version you pass to the `corejs` option matches the version specified in your `package.json`'s `dependencies` section. If it doesn't, you need to run one of the following commands:

  npm install --save core-js@2    npm install --save core-js@3
  yarn add core-js@2              yarn add core-js@3

lord2800
lord2800 previously approved these changes Nov 7, 2019
Copy link
Contributor

@bc-jz bc-jz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bookernath bookernath merged commit ac50765 into bigcommerce:master Nov 7, 2019
@bookernath bookernath deleted the fix-corejs branch November 7, 2019 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants