Skip to content

SweetAlert2 v6.11.5 -> 9.5.4#1617

Merged
bookernath merged 1 commit intobigcommerce:masterfrom
sacr3dc0w:swal9
Jan 14, 2020
Merged

SweetAlert2 v6.11.5 -> 9.5.4#1617
bookernath merged 1 commit intobigcommerce:masterfrom
sacr3dc0w:swal9

Conversation

@sacr3dc0w
Copy link
Contributor

@bigbot
Copy link

bigbot commented Jan 3, 2020

Autotagging @bigcommerce/storefront-team @davidchin

@mattolson
Copy link
Contributor

@sacr3dc0w Thank you for your contribution. Can you address the failing tests?

@sacr3dc0w sacr3dc0w force-pushed the swal9 branch 2 times, most recently from 4207b9f to 78bb38a Compare January 14, 2020 04:22
@bookernath bookernath merged commit 58fcc5a into bigcommerce:master Jan 14, 2020
@sacr3dc0w sacr3dc0w deleted the swal9 branch January 14, 2020 19:43
@bookernath
Copy link
Contributor

FYI @sacr3dc0w, this seems to have introduced a visual regression:

BEFORE
image

AFTER
image

@sacr3dc0w
Copy link
Contributor Author

FYI @sacr3dc0w, this seems to have introduced a visual regression:

BEFORE
image

AFTER
image

Apologies! #1619 should fix that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants