Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SweetAlert2 v6.11.5 -> 9.5.4 #1617

Merged
merged 1 commit into from
Jan 14, 2020
Merged

SweetAlert2 v6.11.5 -> 9.5.4 #1617

merged 1 commit into from
Jan 14, 2020

Conversation

sacr3dc0w
Copy link
Contributor

@bigbot
Copy link

bigbot commented Jan 3, 2020

Autotagging @bigcommerce/storefront-team @davidchin

@mattolson
Copy link
Contributor

@sacr3dc0w Thank you for your contribution. Can you address the failing tests?

@bookernath bookernath merged commit 58fcc5a into bigcommerce:master Jan 14, 2020
@sacr3dc0w sacr3dc0w deleted the swal9 branch January 14, 2020 19:43
@bookernath
Copy link
Contributor

FYI @sacr3dc0w, this seems to have introduced a visual regression:

BEFORE
image

AFTER
image

@sacr3dc0w sacr3dc0w mentioned this pull request Jan 15, 2020
Merged
@sacr3dc0w
Copy link
Contributor Author

FYI @sacr3dc0w, this seems to have introduced a visual regression:

BEFORE
image

AFTER
image

Apologies! #1619 should fix that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bookernath bookernath bookernath approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sacr3dc0w @bigbot @mattolson @bookernath