fix(checkout): CHECKOUT-4233 Cannot add wishlist with item when logged out#1618
Merged
junedkazi merged 1 commit intobigcommerce:masterfrom Jan 14, 2020
mjhmatt:CHECKOUT-4233
Merged
fix(checkout): CHECKOUT-4233 Cannot add wishlist with item when logged out#1618junedkazi merged 1 commit intobigcommerce:masterfrom mjhmatt:CHECKOUT-4233
junedkazi merged 1 commit intobigcommerce:masterfrom
mjhmatt:CHECKOUT-4233
Conversation
|
Autotagging @bigcommerce/storefront-team @davidchin |
davidchin
approved these changes
Jan 8, 2020
Contributor
davidchin
left a comment
davidchin
left a comment
There was a problem hiding this comment.
LGTM 👍We can revisit this in the future if we really want the in-context modal experience.
junedkazi
approved these changes
Jan 14, 2020
Contributor
junedkazi
left a comment
junedkazi
left a comment
There was a problem hiding this comment.
This is weird bcoz it used to work in the modal before. I am fine with this going as is right now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
When a user is logged out and we try to create a wishlist from a PDP page the server attempts to redirect due to the shopper being logged out. Whilst this will work in blueprint, it breaks the user flow on cornerstone, which ends up with the shopper eventually logging in and creating a wishlist without the selected product in it. After discussion with product we have decided to remove the modal for creating a new wishlist
Tickets / Documentation
https://jira.bigcommerce.com/browse/CHECKOUT-4233
Screenshots
Before
After
@bigcommerce/storefront-team @davidchin