feat(search): ES-98 Product filters configured to not display product count show a count when you use the "More" modal#1622
Merged
bc-williamkwon merged 1 commit intobigcommerce:masterfrom Jan 24, 2020
Conversation
|
Autotagging @bigcommerce/storefront-team @davidchin |
bc-dhuynh
reviewed
Jan 24, 2020
Contributor
bc-dhuynh
left a comment
bc-dhuynh
left a comment
There was a problem hiding this comment.
Just a few stylistic changes, other than that, looks pretty invasive
bc-williamkwon
previously approved these changes
Jan 24, 2020
… count show a count in more modal
bc-williamkwon
approved these changes
Jan 24, 2020
Contributor
|
💚 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Product filters that have more than 10 values and are configured within the control panel to not display the product count on the storefront still shows product counts in the "View More" facets modal.
Tickets / Documentation
Add links to any relevant tickets and documentation.
Screenshots (if appropriate)
Before fix:Store (local): https://my-dev-store-740294812.store.bcdev/Product count is being displayed on the "more" modal when
Display Product Countis not selected on Product Filtering.After fix:Store (integration): https://sumayyahasgar1579809024-testington.my-integration.zone/Product count no longer being displayed on the "more" modal when
Display Product Countis not selected on Product FilteringTesting
OFF
4. Turn on/off product count and see if the see more modal is now showing the product count only when specified ✔️OFFdoesn't show the count in the see more modal anymoreteston the storefront (a product I created with over 10 variant option colors)ONshows the count in see more modal