Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(search): ES-98 Product filters configured to not display product count show a count when you use the "More" modal #1622

Merged
merged 1 commit into from
Jan 24, 2020

Conversation

bc-sumi
Copy link
Contributor

@bc-sumi bc-sumi commented Jan 24, 2020

What?

Product filters that have more than 10 values and are configured within the control panel to not display the product count on the storefront still shows product counts in the "View More" facets modal.

Tickets / Documentation

Add links to any relevant tickets and documentation.

Screenshots (if appropriate)

Before fix:
Store (local): https://my-dev-store-740294812.store.bcdev/
Product count is being displayed on the "more" modal when Display Product Count is not selected on Product Filtering.
Screen Shot 2020-01-23 at 4 38 29 PM
Screen Shot 2020-01-23 at 4 38 42 PM

After fix:
Store (integration): https://sumayyahasgar1579809024-testington.my-integration.zone/
Product count no longer being displayed on the "more" modal when Display Product Count is not selected on Product Filtering
Screen Shot 2020-01-23 at 4 36 09 PM
Screen Shot 2020-01-23 at 4 36 17 PM

Testing

  1. Go to https://sumayyahasgar1579809024-testington.my-integration.zone/admin/staff
  2. Make sure search.disable_production_option_facet_counts experiment is turned OFF
  3. Go to Products -> Turn on Product Filtering -> click on color settings to toggle product count

Screen Shot 2020-01-24 at 10 52 13 AM

4. Turn on/off product count and see if the see more modal is now showing the product count only when specified ✔️
  • Toggling count OFF doesn't show the count in the see more modal anymore

Screen Shot 2020-01-24 at 10 52 26 AM

  1. Search for test on the storefront (a product I created with over 10 variant option colors)

Screen Shot 2020-01-24 at 11 06 58 AM

Screen Shot 2020-01-24 at 11 07 05 AM

  • Toggling count ON shows the count in see more modal

Screen Shot 2020-01-24 at 10 52 39 AM

Screen Shot 2020-01-24 at 11 15 20 AM

Screen Shot 2020-01-24 at 11 15 29 AM

@bigbot
Copy link

bigbot commented Jan 24, 2020

Autotagging @bigcommerce/storefront-team @davidchin

Copy link
Contributor

@bc-dhuynh bc-dhuynh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few stylistic changes, other than that, looks pretty invasive

templates/components/faceted-search/show-more-facets.html Outdated Show resolved Hide resolved
templates/components/faceted-search/show-more-facets.html Outdated Show resolved Hide resolved
bc-williamkwon
bc-williamkwon previously approved these changes Jan 24, 2020
Copy link
Contributor

@bc-williamkwon bc-williamkwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM would still reformat code to look like David's recommendation.

@bc-williamkwon bc-williamkwon merged commit 989d553 into bigcommerce:master Jan 24, 2020
@bc-williamkwon
Copy link
Contributor

💚

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants