Replace Karma With Jest #1627
Merged
Replace Karma With Jest #1627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Autotagging @bigcommerce/storefront-team @davidchin |
|
@carsonreinke WOW, thanks for this! I don't feel qualified to review it, but I'll try to get some attention on it from our team soon. |
ncheikh
approved these changes
Feb 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Simply replace Karma with Jest.
Jest is far superior, a lot easier, and more popular. This all started from me trying to write a test with Karma for
assets/js/theme/common/state-country.js, but basically could not even get it to work. Using Jest was simple and easy and definitely appears to be a better direction.Tickets / Documentation
Some oddities:
jest-eventemitter2-transformer.js: required to get Babel andeventemitter2to work together, it is absurd, but is needed unlessstencil-utilsis updatedjest-setup.js: Foundation expects certain things andjsdom(used by Jest) has no layout dimensionsScreenshots (if appropriate)
N/A
Thanks @jbruni and @martinchuka for helping me solve some very complicated problems.