Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent triggering quantity change when pressing enter #1630

Merged
merged 1 commit into from
Feb 2, 2020
Merged

Prevent triggering quantity change when pressing enter #1630

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# Changelog

## Draft
- Prevent triggering quantity change when pressing enter [#1630](https://github.com/bigcommerce/cornerstone/pull/1630)

## 4.4.0 (2020-01-31)
- Add translation key for "read more" blog post link [#1625](https://github.com/bigcommerce/cornerstone/pull/1625)
Expand Down
10 changes: 10 additions & 0 deletions assets/js/theme/common/product-details.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,6 +351,16 @@ export default class ProductDetails {
// update text
viewModel.quantity.$text.text(qty);
});

// Prevent triggering quantity change when pressing enter
this.$scope.on('keypress', '.form-input--incrementTotal', event => {
// If the browser supports event.which, then use event.which, otherwise use event.keyCode
const x = event.which || event.keyCode;
if (x === 13) {
// Prevent default
event.preventDefault();
}
});
}

/**
Expand Down