Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account form classes #1655

Merged
merged 7 commits into from Apr 29, 2020
Merged

Conversation

PeteyRev
Copy link
Contributor

@PeteyRev PeteyRev commented Apr 2, 2020

What?

When editing Account Signup Fields in the Control Panel, there are fields for
CSS Class Name, Inline CSS Style, Field Size that can be customized by the user, however these do not currently work. The data is present , it just was never added via handlebars

Screenshots (if appropriate)

Attach images or add image links here.

oBundle - Lead Dev Sandbox - BigCommerce Control Panel
oBundle - Lead Dev Sandbox - Create Account

@bigbot
Copy link

bigbot commented Apr 2, 2020

Autotagging @bigcommerce/storefront-team @davidchin

package-lock.json Outdated Show resolved Hide resolved
@@ -9846,6 +9860,7 @@
"hoek": "2.x.x"
}
},
<<<<<<< HEAD
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PeteyRev I don't believe the rebase went well since I am seeing these line.

@@ -9862,6 +9877,12 @@
"version": "6.0.0",
"resolved": "https://registry.npmjs.org/wreck/-/wreck-6.0.0.tgz",
"integrity": "sha1-T0CGaWHl14rOBPMqa38x8/PFFjg=",
=======
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

"version": "6.3.0",
"resolved": "https://registry.npmjs.org/wreck/-/wreck-6.3.0.tgz",
"integrity": "sha1-oTaXafB7u2LWo3gzanhx/Hc8dAs=",
>>>>>>> 4bd50865cf4e39814a9a0c485c5643cc99799020
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

@junedkazi junedkazi merged commit 8b51932 into bigcommerce:master Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants