Reset cart quantity to 0 if we get a 404 for the cart #1661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Autotagging @bigcommerce/storefront-team @davidchin |
bookernath
commented
Apr 22, 2020
| @@ -69,7 +69,12 @@ export default function (secureBaseUrl, cartId) { | |||
| const cartQtyPromise = new Promise((resolve, reject) => { | |||
| utils.api.cart.getCartQuantity({ baseUrl: secureBaseUrl, cartId }, (err, qty) => { | |||
| if (err) { | |||
| reject(err); | |||
| // If this appears to be a 404 for the cart ID, set cart quantity to 0 | |||
| if (err === 'Not Found') { | |||
There was a problem hiding this comment.
Why the messy string comparison?
Our request implementation only returns the string of the response code, not the actual error object:
https://github.com/bigcommerce/stencil-utils/blob/master/src/lib/request.js#L127
As such, I have nothing else to match on without a significant refactor.
Fortunately, the fallback behavior here is pretty elegant.
bc-jz
approved these changes
Apr 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
If we get a 404 for the cart, set the quantity to 0 for the cart preview.
Fixes a bug where the quantity will not update back to 0 after a successful checkout.
Tickets / Documentation