Add a better admin bar #1664
Merged
Add a better admin bar #1664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Autotagging @bigcommerce/storefront-team @davidchin |
bookernath
force-pushed
the
better-admin-bar
branch
from
7193408
to
512b2d6
Compare
bookernath
commented
Apr 28, 2020
| } | ||
|
|
||
| // Set admin cookie if appropriate | ||
| if (window.URLSearchParams && window.URL && (new URL(document.location)).searchParams.get('ctk')) { |
There was a problem hiding this comment.
I'm simply matching on the query param used when we launch the storefront from the CP. While this would be easy to forge, it doesn't really reveal anything particularly sensitive - every button you can click loads the CP, which is behind the merchant login.
bookernath
commented
Apr 28, 2020
| @@ -1 +1 @@ | |||
| <svg width="26" height="26" viewBox="0 0 26 26" xmlns="http://www.w3.org/2000/svg"><title>Logo B</title><path d="M17.647 12.125h-3.323c-.11 0-.197.087-.197.194v2.327c0 .107.087.193.197.193h3.323c.95 0 1.542-.524 1.542-1.357 0-.795-.594-1.358-1.543-1.358zm-2.62-2.423h3.233c2.51 0 3.988 1.57 3.988 3.296 0 1.35-.915 2.345-1.885 2.78-.155.07-.15.283.01.346 1.128.443 1.94 1.623 1.94 3 0 1.96-1.305 3.512-3.837 3.512h-6.96c-.11 0-.197-.087-.197-.194v-9.03L.237 24.49c-.51.508-.148 1.378.57 1.378h24.254c.446 0 .808-.362.808-.808V.81c0-.72-.87-1.08-1.38-.572L15.03 9.702zm-.703 7.562c-.11 0-.197.087-.197.194v2.56c0 .106.087.193.197.193h3.44c1.05 0 1.682-.542 1.682-1.472 0-.815-.593-1.474-1.68-1.474h-3.442z" fill="#FFF" fill-rule="evenodd"/></svg> | |||
| <svg width="26" height="26" viewBox="0 0 26 26" xmlns="http://www.w3.org/2000/svg"><title>Logo B</title><path d="M17.647 12.125h-3.323c-.11 0-.197.087-.197.194v2.327c0 .107.087.193.197.193h3.323c.95 0 1.542-.524 1.542-1.357 0-.795-.594-1.358-1.543-1.358zm-2.62-2.423h3.233c2.51 0 3.988 1.57 3.988 3.296 0 1.35-.915 2.345-1.885 2.78-.155.07-.15.283.01.346 1.128.443 1.94 1.623 1.94 3 0 1.96-1.305 3.512-3.837 3.512h-6.96c-.11 0-.197-.087-.197-.194v-9.03L.237 24.49c-.51.508-.148 1.378.57 1.378h24.254c.446 0 .808-.362.808-.808V.81c0-.72-.87-1.08-1.38-.572L15.03 9.702zm-.703 7.562c-.11 0-.197.087-.197.194v2.56c0 .106.087.193.197.193h3.44c1.05 0 1.682-.542 1.682-1.472 0-.815-.593-1.474-1.68-1.474h-3.442z" fill="#000" fill-rule="evenodd"/></svg> | |||
There was a problem hiding this comment.
Just changing the fill color to match new design.
bookernath
force-pushed
the
better-admin-bar
branch
from
512b2d6
to
5a95374
Compare
junedkazi
reviewed
Apr 28, 2020
| class: 'adminBar', | ||
| }); | ||
|
|
||
| $element.html(`<div class="adminBar-logo"> |
There was a problem hiding this comment.
I wonder if we can move the markup into a separate file 🍹
There was a problem hiding this comment.
It's probably easier to remove later like this?
assets/js/theme/global.js
Outdated
| @@ -26,7 +29,9 @@ export default class Global extends PageManager { | |||
| menu(); | |||
| mobileMenuToggle(); | |||
| privacyCookieNotification(); | |||
| maintenanceMode(this.context.maintenanceMode); | |||
| if (themeSettings['show-admin-bar']) { | |||
| adminBar(storeHash, maintenanceModeSettings, JSON.parse(adminBarLanguage), productId, categoryId); | |||
There was a problem hiding this comment.
Instead of defining all these params would it make sense to pass the entire context along with the page type so we can build contextual links for entities based on page type.
There was a problem hiding this comment.
I thought about that, but I didn't want to inject too much as whatever is injected will show up in HTML; IDs seem non-sensitive. And I'm trying to make this easy to remove before too long so we can remove admin bar from the theme entirely.
junedkazi
previously approved these changes
Apr 28, 2020
bookernath
force-pushed
the
better-admin-bar
branch
2 times, most recently
from
d9150ee
to
22a887f
Compare
bookernath
force-pushed
the
better-admin-bar
branch
from
22a887f
to
2e87e6f
Compare
bookernath
force-pushed
the
better-admin-bar
branch
from
2e87e6f
to
9baf183
Compare
bookernath
force-pushed
the
better-admin-bar
branch
from
9baf183
to
996bee4
Compare
junedkazi
previously approved these changes
May 28, 2020
bookernath
force-pushed
the
better-admin-bar
branch
from
996bee4
to
a5008a0
Compare
junedkazi
previously approved these changes
May 28, 2020
bookernath
force-pushed
the
better-admin-bar
branch
from
a5008a0
to
77a9ea0
Compare
junedkazi
approved these changes
May 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adds a persistent admin bar for store control panel users to make it easier to launch actions from the storefront.
Handles 3 different states:
prelaunchmodemaintenancemode...with appropriate contextual actions for each.
Can be hidden (per-user), and can also be disabled via a theme setting.
Gracefully degrades at various responsive breakpoints.
Tickets / Documentation
Screenshots (if appropriate)
smallbreakpoint (completely hidden)mediumbreakpoint (condensed)largebreakpoint (everything)A page that doesn't support a contextual action, only opening in Page Builder:
Maintenance mode w/ mouseover tooltip:
Live mode:
ping @bigcommerce/merc-team @bigcommerce/storefront-team