feat(checkout): MCU-427 Display modal before switching currencies #1668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Autotagging @bigcommerce/storefront-team @davidchin |
lpschz
reviewed
May 7, 2020
mjhmatt
force-pushed
the
MCU-427
branch
2 times, most recently
from
8b2c5f7
to
49c4c36
Compare
|
@mjhmatt please rebase |
mjhmatt
force-pushed
the
MCU-427
branch
4 times, most recently
from
6a3eb56
to
5377e15
Compare
davidchin
reviewed
Jun 2, 2020
mjhmatt
force-pushed
the
MCU-427
branch
4 times, most recently
from
4dfc3a0
to
6cb9cb6
Compare
davidchin
previously approved these changes
Jun 9, 2020
bookernath
previously approved these changes
Jun 9, 2020
bookernath
reviewed
Jun 9, 2020
assets/js/theme/global.js
Outdated
| @@ -22,7 +22,7 @@ export default class Global extends PageManager { | |||
| } = this.context; | |||
| cartPreview(secureBaseUrl, cartId); | |||
| quickSearch(); | |||
| currencySelector(); | |||
| currencySelector(this.context.cartId); | |||
There was a problem hiding this comment.
🍹 as cartId is already destructured above, you could just reference cartId
mjhmatt
force-pushed
the
MCU-427
branch
3 times, most recently
from
dc3c467
to
d0b70f0
Compare
|
@mjhmatt @davidchin is this good to go ? |
mjhmatt
force-pushed
the
MCU-427
branch
2 times, most recently
from
e178995
to
f582f77
Compare
|
Sorry for the delay. Yes @junedkazi this is finished now, was just waiting to finalise the backend PR. |
junedkazi
approved these changes
Jun 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Before switching currencies in the case of a cart containing a gift certificate/promotion we will need to notify the customer as they may be removed from cart once the currency is changed.
Tickets / Documentation
https://jira.bigcommerce.com/browse/MCU-427
Screenshots (if appropriate)
@bigcommerce/checkout