Bump jQuery version, expose jquery globally so it doesn't need to be loaded separately #1671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junedkazi
reviewed
May 12, 2020
bookernath
force-pushed
the
update-jq
branch
3 times, most recently
from
6670602
to
f728b90
Compare
…loaded separately
junedkazi
approved these changes
May 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Bump jQuery version to address a CVE. I've confirmed the main change (related to htmlPrefilter()) does not affect us.
I also exposed
$on the window object - because I see that lots of custom themes feel the need to separately include jQuery, which will be bad for performance. Exposing our existing bundle jQuery gets rid of the need to do this.