Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(payments): INT-2593 Display wallet on drop-down section from cart icon #1687

Merged
merged 1 commit into from
Jun 15, 2020

Conversation

JorgeMolinaA
Copy link
Contributor

@JorgeMolinaA JorgeMolinaA commented Jun 10, 2020

What?

Adding additionalCheckoutButtons on the cart-preview and respective scss
In order to displays wallet buttons on the drop-down section from the cart icon on the storefront

Tickets / Documentation

INT-2593
INT-2370(research)

BCApp PR needs to be merge first

Screenshots

image

@bigbot
Copy link

bigbot commented Jun 10, 2020

Autotagging @bigcommerce/storefront-team @davidchin

mauricio-sg
mauricio-sg previously approved these changes Jun 11, 2020
Copy link

@mauricio-sg mauricio-sg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Maybe it is worth doing some kind of inheritance to keep the file DRY as it is sharing the same code with .cart-additionalCheckoutButtons

@pgonzalezr
Copy link

Looks good from QE side, tested this with masterpass, google pay, apple pay, paypal in FF, Chrome & Safari
Screen Shot 2020-06-11 at 3 45 01 PM

Copy link
Contributor

@PharaohAsh PharaohAsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@clopezh
Copy link

clopezh commented Jun 12, 2020

@PharaohAsh Thank you for the approval! This PR will be ready to merge once BCapp PR will be merged. (I can't add labels to this PR I don't know why)

@PharaohAsh
Copy link
Contributor

@junedkazi please?

@PascalZajac PascalZajac merged commit 25ba201 into bigcommerce:master Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants