Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(search): ES-1322 fixed the collapse and expand issue for custom filter without no special characters #1693

Merged
merged 1 commit into from
Jun 16, 2020

Conversation

bc-krishsenthilraj
Copy link
Contributor

@bc-krishsenthilraj bc-krishsenthilraj commented Jun 15, 2020

What?

Custom filter without '&' is not collapsable

Since custom filter without & and if it has empty space between the words (Ex: Custom Size), the data-collapsible element is broken in the html source. With this fix,

Tickets / Documentation

Screenshots (if appropriate)

  1. All the filters are collapsed
    image

  2. Standard filters are expanded
    image

  3. Both custom filters are expanded
    image

  4. One custom collapsed (custom filter without & in it) and other one is expanded (custom filter with & in it)
    image

  5. One custom collapsed (custom filter with& in it) and other one is expanded (custom filter without & in it)
    image

@bigbot
Copy link

bigbot commented Jun 15, 2020

Autotagging @bigcommerce/storefront-team @davidchin

@junedkazi junedkazi merged commit 0f8d5ad into bigcommerce:master Jun 16, 2020
@bc-aodvak
Copy link

Tested with attached to the ticket theme. Looks good 💚

@tvlgiao
Copy link

tvlgiao commented Jun 18, 2020

Doesn't work if the filter name contains special characters %+&:()?
I'd suggest using {{dashcase ...}} to remove all non-word characters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants