fix(search): ES-1322 fixed the collapse and expand issue for custom filter without no special characters #1693
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Custom filter without '&' is not collapsable
Since custom filter without
&
and if it hasempty space
between the words (Ex: Custom Size
), thedata-collapsible
element is broken in the html source. With this fix,Tickets / Documentation
Screenshots (if appropriate)
All the filters are collapsed
![image](https://user-images.githubusercontent.com/39140274/84715914-bba51e00-af26-11ea-948a-556d0c3d3ee5.png)
Standard filters are expanded
![image](https://user-images.githubusercontent.com/39140274/84716182-48e87280-af27-11ea-8bdb-7ad0ac28f33a.png)
Both custom filters are expanded
![image](https://user-images.githubusercontent.com/39140274/84715950-cd86c100-af26-11ea-921a-0d58ca743233.png)
One custom collapsed (custom filter without
![image](https://user-images.githubusercontent.com/39140274/84716076-0fb00280-af27-11ea-8a25-baed4fc199b2.png)
&
in it) and other one is expanded (custom filter with&
in it)One custom collapsed (custom filter with
![image](https://user-images.githubusercontent.com/39140274/84716108-25bdc300-af27-11ea-90e4-c5ec323a5068.png)
&
in it) and other one is expanded (custom filter without&
in it)