fix(storefront): BCTHEME-65 Make email subscribe messages readable by… #1731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… screen reader in context
|
Autotagging @bigcommerce/storefront-team @davidchin |
golcinho
approved these changes
Jul 21, 2020
bc-alexsaiannyi
approved these changes
Jul 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… screen reader in context
What?
Error and validation message should appear both on the screen and be read in context on the email subscribe input box when using a screen reader.
Currently a screen reader will read the error message as it appears in the body but it will not repeat the message contextually within the email input box.
Tickets / Documentation
Ticket
Screenshots (if appropriate)
@bc-as could you verify the expected result on screenshots?