fix(storefront): BCTHEME-129 Quick search aria hidden element should … #1739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yurytut1993
approved these changes
Jul 27, 2020
|
Autotagging @bigcommerce/storefront-team @davidchin |
bc-alexsaiannyi
approved these changes
Jul 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…not be focusable
What?
The quick search hidden search box currently has the attribute aria-hidden to indicate that it is visually hidden, however, this causes it to be ignored by screen readers.
The search box should use the attribute display:none to properly hide this element.
Tickets / Documentation
Ticket
Screenshots (if appropriate)
Video is attached in ticket