fix(storefront): STRF-8599 Drop Jquery: Replaced event's current target to the element passed from utils(on hook) #1821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Autotagging @bigcommerce/storefront-team @davidchin |
…et to the element passed from utils(on hook)
junedkazi
reviewed
Sep 16, 2020
| @@ -139,8 +139,8 @@ export default class Cart extends PageManager { | |||
| this.bindGiftWrappingForm(); | |||
| }); | |||
|
|
|||
| utils.hooks.on('product-option-change', (event, option) => { | |||
| const $changedOption = $(option); | |||
| utils.hooks.on('product-option-change', (event, currentTarget) => { | |||
There was a problem hiding this comment.
Don't we need to change places where we do the bind to pass currentTarget for all of them ?
There was a problem hiding this comment.
I've already changed it in stencil-utils:
https://github.com/bigcommerce/stencil-utils/blob/master/src/hooks/product.js
junedkazi
approved these changes
Oct 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…
What?
Changed the behaviour of the stencil utils event handlers. Target element is now taken not from event.currentTarget, but passed from the stencil-utils eventemitter.
Tickets / Documentation
https://jira.bigcommerce.com/browse/STRF-8599
Screenshots (if appropriate)
Attach images or add image links here.