Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(search): ES-1590 display error message if search fails #1885

Merged
merged 1 commit into from
Oct 30, 2020

Conversation

kvnwang
Copy link
Contributor

@kvnwang kvnwang commented Oct 22, 2020

What?

Tested with https://github.com/bigcommerce/bigcommerce/pull/37764
If a search error happens, display error message instead of server error page.

Screenshots (if appropriate)

Screen Shot 2020-10-22 at 3 42 04 PM

@bigbot
Copy link

bigbot commented Oct 22, 2020

Autotagging @bigcommerce/themes-team

@kvnwang kvnwang force-pushed the ES-1590 branch 4 times, most recently from 9d1e504 to 9e088e9 Compare October 27, 2020 18:14
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@BC-tymurbiedukhin BC-tymurbiedukhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bc-aodvak
Copy link

💚

@bc-dhuynh
Copy link
Contributor

:shipit:

@bc-dhuynh bc-dhuynh merged commit 687624d into bigcommerce:master Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants