fix(storefront): BCTHEME-305 Price Lists - Price in the cart is not u… #1893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pdated when changing currency on mobile
BC-tymurbiedukhin
force-pushed
the
BCTHEME-305
branch
from
dcc22d2
to
ed7d5af
Compare
|
Autotagging @bigcommerce/themes-team |
bc-alexsaiannyi
approved these changes
Nov 5, 2020
yurytut1993
reviewed
Nov 9, 2020
Comment on lines
+28
to
+30
| <strong>{{name}}</strong> | ||
| {{else}} | ||
| {{name}} | ||
| {{name}} |
There was a problem hiding this comment.
LGTM in total, but could you please remove trailing spaces?
yurytut1993
approved these changes
Nov 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…pdated when changing currency on mobile
What?
The price is not updated correctly in the cart/checkout after changing the currency. This looks to be specific to the mobile version of the site and
Tickets / Documentation
Jira Ticket
Screenshots (if appropriate)